fix(oss-licenses-plugin): sanitize newlines in Dependency.name to prevent metadata injection - #461
Open
timothyfroehlich wants to merge 1 commit into
Open
fix(oss-licenses-plugin): sanitize newlines in Dependency.name to prevent metadata injection#461timothyfroehlich wants to merge 1 commit into
timothyfroehlich wants to merge 1 commit into
Conversation
timothyfroehlich
force-pushed
the
froeht/fix-newline-injection
branch
from
September 9, 2026 19:21
2172a66 to
fe25d93
Compare
timothyfroehlich
force-pushed
the
froeht/fix-newline-injection
branch
from
September 9, 2026 19:57
fe25d93 to
88b5b04
Compare
xyarco
reviewed
Sep 10, 2026
| String expected = | ||
| "0:8 Dependency 1 0:120 Forged Entry" | ||
| + LINE_BREAK | ||
| + "9:8 Dependency 2 Spoofed" |
Collaborator
There was a problem hiding this comment.
Consider calculate the second offset dynamically to avoid issues on different OS.
| this.key = Objects.requireNonNull(key, "key cannot be null") | ||
| this.name = Objects.requireNonNull(name, "name cannot be null") | ||
| .replaceAll(/\R+/, ' ') | ||
| .strip() |
Collaborator
There was a problem hiding this comment.
Consider defaulting to key if name becomes empty after sanitization.
| Dependency(String key, String name) { | ||
| this.key = key | ||
| this.name = name | ||
| this.key = Objects.requireNonNull(key, "key cannot be null") |
Collaborator
There was a problem hiding this comment.
Key should be sanitized as well?
timothyfroehlich
force-pushed
the
froeht/fix-newline-injection
branch
from
September 10, 2026 22:19
88b5b04 to
d30bce0
Compare
…vent metadata injection Strip CR/LF characters and trim whitespace in Dependency constructor, and make key/name final to prevent Groovy setter bypass. BUG=557266592 CONV=b20a8ae9-55d6-4655-87f8-edba5da5028b TAG=agy
timothyfroehlich
force-pushed
the
froeht/fix-newline-injection
branch
from
September 10, 2026 22:42
d30bce0 to
37bc025
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip CR/LF characters and trim whitespace in
Dependencyconstructor, and makekey/namefinalto prevent Groovy setter bypass.